Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ratelimit configuring in apk conf if the ratelimit policy is unlimited #1192

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

CrowleyRajapakse
Copy link
Contributor

Purpose

fixes wso2/apk#2458

@CrowleyRajapakse CrowleyRajapakse added the trigger-action gradle build for apk-agent label Sep 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 16.96%. Comparing base (e1547dd) to head (5400b4b).
Report is 110 commits behind head on master.

Files with missing lines Patch % Lines
apim-apk-agent/pkg/transformer/transformer.go 50.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1192       +/-   ##
===========================================
- Coverage   38.76%   16.96%   -21.81%     
===========================================
  Files          19       44       +25     
  Lines        2056     5099     +3043     
===========================================
+ Hits          797      865       +68     
- Misses       1197     4155     +2958     
- Partials       62       79       +17     
Flag Coverage Δ
apim-apk-agent 16.96% <50.00%> (-21.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrowleyRajapakse CrowleyRajapakse merged commit 1f04e23 into wso2:master Sep 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trigger-action gradle build for apk-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent should not create unlimited RL policies
3 participants