-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude system apps in applications GET impl #6026
Conversation
…tation. Introduce systemPortals server level config and implementation to exclude the mentioned systemPortals in get applications api response.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6026 +/- ##
============================================
+ Coverage 40.12% 40.19% +0.06%
+ Complexity 14198 14187 -11
============================================
Files 1736 1738 +2
Lines 117216 116944 -272
Branches 20200 20126 -74
============================================
- Hits 47035 47000 -35
+ Misses 62938 62730 -208
+ Partials 7243 7214 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...n/java/org/wso2/carbon/identity/application/mgt/dao/PaginatableFilterableApplicationDAO.java
Outdated
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationMgtDBQueries.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationMgtDBQueries.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationMgtDBQueries.java
Show resolved
Hide resolved
Let's run the PR builder before merging. |
...rc/main/java/org/wso2/carbon/identity/application/mgt/ApplicationPaginationAndSearching.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/carbon/identity/application/mgt/ApplicationPaginationAndSearching.java
Outdated
Show resolved
Hide resolved
...mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ApplicationManagementService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/carbon/identity/application/mgt/ApplicationPaginationAndSearching.java
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/application/mgt/dao/PaginatableFilterableApplicationDAO.java
Outdated
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/application/mgt/dao/PaginatableFilterableApplicationDAO.java
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Show resolved
Hide resolved
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Show resolved
Hide resolved
...c/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/CacheBackedApplicationDAO.java
Show resolved
Hide resolved
Make sure to update the integration tests cover the new cases. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11367350879
Introduce excludeSystemPortals API query param and following implementation.
Introduce systemPortals server level config and implementation to exclude the mentioned systemPortals in get applications api response.
Proposed changes in this pull request