-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6987 Add dynamic list Automatic Lazy Render exclusions #6988
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
inc/Engine/Optimization/LazyRenderContent/Frontend/Controller.php
Outdated
Show resolved
Hide resolved
inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php
Outdated
Show resolved
Hide resolved
inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Regex.php
Outdated
Show resolved
Hide resolved
inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/SimpleHtmlDom.php
Outdated
Show resolved
Hide resolved
inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/SimpleHtmlDom.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tabrisrp, thank you for this PR.
Exploratory went smoothly, test execution too.
testrail-report-638.pdf
Description
Fixes #6987
Exclude patterns from ALR pulled from the backend with the dynamic lists
Type of change
Detailed scenario
Use the filter
rocket_lrc_exclusions
likewpm_apply_filters_typed('array', 'rocket_lrc_exclusions', $array_of_exclusions )
where$array_of_exclusions
is an array of excluded element.Then load a page and notice that hashes won't be added to excluded element(s).
Technical description
Documentation
A new filter has been added
rocket_lrc_exclusions
in order to add exclusions to LRC.Mandatory Checklist
Code validation
Code style