Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6987 Add dynamic list Automatic Lazy Render exclusions #6988

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Sep 23, 2024

Description

Fixes #6987

Exclude patterns from ALR pulled from the backend with the dynamic lists

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Use the filter rocket_lrc_exclusions like wpm_apply_filters_typed('array', 'rocket_lrc_exclusions', $array_of_exclusions ) where $array_of_exclusions is an array of excluded element.
Then load a page and notice that hashes won't be added to excluded element(s).

Technical description

Documentation

A new filter has been added rocket_lrc_exclusions in order to add exclusions to LRC.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: OCI Optimize Critical Images labels Sep 23, 2024
Copy link

codacy-production bot commented Sep 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 975503d1 86.96% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (975503d) Report Missing Report Missing Report Missing
Head commit (e4d2713) 37893 16633 43.89%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6988) 23 20 86.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Miraeld Miraeld marked this pull request as ready for review September 24, 2024 05:13
@Tabrisrp Tabrisrp added this to the 3.17.0.2 milestone Sep 24, 2024
@Tabrisrp Tabrisrp requested a review from a team September 24, 2024 13:37
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tabrisrp, thank you for this PR.
Exploratory went smoothly, test execution too.
testrail-report-638.pdf

@Tabrisrp Tabrisrp added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit 9d4f8ca Sep 24, 2024
12 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/6987-alr-exclusions branch September 24, 2024 15:30
Tabrisrp added a commit that referenced this pull request Sep 24, 2024
Co-authored-by: Gael Robin <robin.gael@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: OCI Optimize Critical Images type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New backend section to handle the Automatic Lazy Rendering exclusions
5 participants