Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LRC filters prefix #6947

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Sep 4, 2024

Description

Standardize the prefix for LRC filters from rocket_lazy_render_content_ to rocket_lrc_.

Type of change

Detailed scenario

The new filters directly replace the old one with no deprecation since it was not publicly released.

Technical description

Documentation

For consistancy, renaming the LRC filters so they all use the same prefix.

Mandatory Checklist

Code validation

  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Tabrisrp Tabrisrp added type: sub-task Indicates the issue is a sub-task linked to an epics card module: ALR Issues related to the Automatic Lazy Rendering feature labels Sep 4, 2024
@Tabrisrp Tabrisrp added this to the 3.17 milestone Sep 4, 2024
@Tabrisrp Tabrisrp requested a review from a team September 4, 2024 15:13
@Tabrisrp Tabrisrp self-assigned this Sep 4, 2024
@Tabrisrp Tabrisrp changed the base branch from develop to feature/lrc September 4, 2024 15:14
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4d7b54b) 37912 16541 43.63%
Head commit (a20f723) 37934 (+22) 16551 (+10) 43.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6947) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codacy-production bot commented Sep 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (554dc2a) 37935 16552 43.63%
Head commit (f6d3fa0) 37913 (-22) 16542 (-10) 43.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6947) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@MathieuLamiot
Copy link
Contributor

I merged #6949 into LRC branch, which adds a new test on a filter so I updated this PR with develop and fixed the test.

@MathieuLamiot
Copy link
Contributor

Documentation is up to date ✅
I checked the new filters with code snippets and they behave as expected.

@MathieuLamiot MathieuLamiot merged commit 5711a09 into feature/lrc Sep 5, 2024
12 of 13 checks passed
@MathieuLamiot MathieuLamiot deleted the chore/update-filters-prefix branch September 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants