Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6885 Hosting cache not cleared when clearing Performance Hints for current URL #6921

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #6885
Make sure hosting cached is cleared when user click on Clear Performance Hints for current URL

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Same as described in the issue #6885

Technical description

Add performance hints filter for varnish addon.

Documentation

Add performance hints callback to varnish subscriber.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

Copy link

codacy-production bot commented Aug 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7150c17) 37909 16525 43.59%
Head commit (747197b) 37910 (+1) 16525 (+0) 43.59% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6921) 6 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@jeawhanlee jeawhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Sir
Can you update test here to add this new hook.

@Miraeld
Copy link
Contributor

Miraeld commented Aug 30, 2024

Did QA on it, here is the result of the related test plan
testrail-report-634.pdf

@wordpressfan wordpressfan merged commit 88bfea5 into feature/lrc Aug 30, 2024
12 of 13 checks passed
@wordpressfan wordpressfan deleted the fix/6885-fix-hosting-cache-cleared branch August 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting cache not cleared when clearing Performance Hints for current URL
4 participants