-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #5992: Get rid of the cache tab #6013
Closes #5992: Get rid of the cache tab #6013
Conversation
@jeawhanlee Where are we at with this PR? |
@piotrbak Done, just awaiting assets from the Product Design team |
…y cache_mobile enabled
…nerating advanced cache file
@jeawhanlee Thank you for the update scenario 2 is fixed. Note: in both 1,2 , if we changed permalinks, mobile version will be preloaded. However, clear and preload cache after that won't preload mobile @jeawhanlee can you please check. @piotrbak what do you think? |
@jeawhanlee Thanks for the update.
And update where:
@piotrbak Since manual clear and preload is the workaround when no automatic preload happens, do you think further improvement is needed here or shall we proceed with test execution as is for now? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
@jeawhanlee @Tabrisrp Thanks for the updates. Please find exploratory test notes below (WIP)
|
Description
This PR removes the cache tab as described in the epic
Fixes #5992
Type of change
Is the solution different from the one proposed during the grooming?
No
How Has This Been Tested?
Automated & Manual Tests
Checklist: