Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #5992: Get rid of the cache tab #6013

Merged
merged 70 commits into from
Apr 29, 2024

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Jun 28, 2023

Description

This PR removes the cache tab as described in the epic

Fixes #5992

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

Automated & Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement epics 🔥 For large tasks or features, broken into smaller issues. module: user interface labels Jun 28, 2023
@jeawhanlee jeawhanlee added this to the 3.16 milestone Jun 28, 2023
@jeawhanlee jeawhanlee self-assigned this Jun 28, 2023
@vmanthos vmanthos self-requested a review June 28, 2023 12:26
@piotrbak
Copy link
Contributor

piotrbak commented Jul 9, 2023

@jeawhanlee Where are we at with this PR?

@jeawhanlee
Copy link
Contributor Author

jeawhanlee commented Jul 9, 2023

@jeawhanlee Where are we at with this PR?

@piotrbak Done, just awaiting assets from the Product Design team

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 21, 2023

@jeawhanlee Thank you for the update scenario 2 is fixed.
1- Scenario 1 mentioned above still not working + even clear and preload won't preload mobile or reenable preload feature
2- Regarding import, it's fixed if the imported file has a mobile cache on, separate off, or both off. however if the mobile cache is off and the separate cache is on, then we enable mobile cache at tools, mobile won't be preloaded even with clear and preload or re-enable preload feature

Note: in both 1,2 , if we changed permalinks, mobile version will be preloaded. However, clear and preload cache after that won't preload mobile

@jeawhanlee can you please check. @piotrbak what do you think?

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 25, 2023

@jeawhanlee Thanks for the update.
Now Import settings where:

  • mobile cache on and separate cache off or both mobile and separate cache are on => preload will occur for both desktop and mobile
  • mobile cache off and separate mobile off => When click enable mobile cache, the desktop will be preloaded but not mobile (clear and preload will preload both desktop and mobile)
  • mobile cache off and separate mobile on => When click enable mobile cache, nothing happens in cache ( note: on trunk if we enable/disable mobile cache while separate mobile is on, nothing will be preloaded), however, if we clear and preload both mobile and desktop will be preloaded

And update where:

  • mobile cache on and separate cache off or both mobile and separate cache are on => we need to refresh admin so preload works, it will preload both desktop and mobile
  • mobile cache off and separate mobile cache off then click enable mobile cache => cache is preloaded for both mobile and desktop
  • mobile cache off but separate on then click enable mobile cache nothing preloaded till manually clear and preload cache (after update, need to refresh so that the preload occurs)

@piotrbak Since manual clear and preload is the workaround when no automatic preload happens, do you think further improvement is needed here or shall we proceed with test execution as is for now?

@Tabrisrp Tabrisrp changed the base branch from develop to branch-3.16 April 17, 2024 15:14
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4419a421 14.55% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4419a42) Report Missing Report Missing Report Missing
Head commit (e53bf26) 36033 8370 23.23%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6013) 110 16 14.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Tabrisrp Tabrisrp removed the request for review from vmanthos April 23, 2024 17:51
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Apr 26, 2024

@jeawhanlee @Tabrisrp Thanks for the updates. Please find exploratory test notes below (WIP)

  • Fresh install and activate the PR => only desktop is preloaded while mobile is not preloaded although it should (for retest, we need to retest with WP sitemap, using SEO plugin and custom sitemap)=> update after retesting this with zip then with the branch it works

@Tabrisrp Tabrisrp merged commit 0aed49b into branch-3.16 Apr 29, 2024
8 of 11 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/5992-get-rid-of-the-cache-tab branch April 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epics 🔥 For large tasks or features, broken into smaller issues. module: user interface type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the Cache Tab
6 participants