Migrate to alpine #1
Conversation
There was a problem hiding this comment.
Thanks for the contribution Ivan. A version of the image that is based on Alpine will indeed be much smaller. Though I would still like to keep the Ubuntu version around as well, as other images like dockup-mongo may depend on it.
So my suggestion would be to integrate your changes into a new alpine branch, with a corresponding Docker image tag on the hub. As you also installed bash, changes are minimal, so maintaining both should not be a hassle.
What do you think about that?
|
|
||
| # RUN echo '@testing http://nl.alpinelinux.org/alpine/edge/testing' >> /etc/apk/repositories && \ | ||
| # apk add --update --no-cache curl awscli@testing bash grep | ||
| # RUN apt-get update && apt-get install -y python-pip curl && pip install awscli |
There was a problem hiding this comment.
What about these commented lines? I guess they can be removed?
There was a problem hiding this comment.
Yeah, these lines are here by mistake
|
Having a separate branch for alpine is a nice idea. If you create an alpine branch here and link it to the docker hub it would be great. |
|
Another idea, since migration to alpine does not require any modification for the script itself, perhaps it is better to create a separate Dockerfile.alpine file and link it to a separate tag on the Docker Hub. It is easier then maintain two separate branches. I can create a PR for that. |
|
I was unsure if that's supported by Docker Hub automated builds, but this post suggests it does, so I would like to give your idea a try. Would be great if you create the PR. |
It is smaller and much faster to build!