Error handling for tokio_postgres::Connection created manually
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a new method `AsyncPgConnection::try_from_client_and_connection` that handles the details of driving the underlying `tokio_postgres::Connection`. Connections constructed using this method will now benefit from the same error handling provided by `AsyncPgConnection::establish`. * Adds a small section about TLS to the `AsyncPgConnection` documentation. * Updates the TLS examples for Postgres to use the new method.
weiznich
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #184
I was struggling a little bit to write docs that didn't leak too much of the implementation details, so I chose to keep it minimal. Happy to push fixups.
Adds a new method
AsyncPgConnection::try_from_client_and_connectionthat handles the details of driving the underlyingtokio_postgres::Connection. Connections constructed using this method will now benefit from the same error handling provided byAsyncPgConnection::establish.Adds a small section about TLS to the
AsyncPgConnectiondocumentation.Updates the TLS examples for Postgres to use the new method.