Export translation entries without references to files #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokodok
changed the title
|
The breaking change from WP-CLI 2.9.0 to 2.10.0 must be somewhere in here, but I was not able to locate it yet: wp-cli/i18n-command@v2.4.4...v2.6.0 |
|
The export has actually nothing to do with WP-CLI. This was a bug in Traduttore since the beginning. On w.org, this was already fixed 3 years ago but never copied to Traduttore. |
|
@ocean90 So would you say this simple if clause fix from WordPress.org is ready to be merged and deployed? |
ocean90
reviewed
Feb 16, 2024
ocean90
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Yes, the change without the whitespace looks good!
https://github.com/wearerequired/traduttore/pull/265/files?diff=unified&w=1
ocean90
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered that Traduttore was not working properly any more since updating WP-CLI to 2.10.0 from 2.9.0. For some projects, all translations would end up in the JSON file and leaving the PO file empty.
I originally just wanted to get the strings for "Template name of the Theme" into the PO file. After the Update to WP-CLI 2.10.0 and with this commit, this also works now.
How has this been tested?
Screenshots
WP-CLI 2.9.0 (without this commit)
WP-CLI 2.10.0 (without this commit)
The PO file is now empty.
WP-CLI 2.10.0 (with this commit)
Types of changes
Checklist: