bug: fix structured logging crash #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configures the log layer to have an appropriate FormatFields when using json, or uses the default Full configuration partially addresses wasmCloud#147 Signed-off-by: Evan Mattiza <emattiza@gmail.com>
emattiza
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
thomastaylor312
approved these changes
Sep 12, 2023
|
Oh and also, I’d love the idea of refactoring this. I figured it out once and have copy pasted since then 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configures the log layer to have an appropriate FormatFields when using json, or uses the default Full configuration
Feature or Problem
Crashing when running WADM_TRACING_ENABLED=true WADM_STRUCTURED_LOGGING=true RUST_LOG=debug RUST_BACKTRACE=1 cargo run --features cli --bin wadm
WADM_TRACING_ENABLED=true WADM_STRUCTURED_LOGGING=true cargo run --features cli --bin wadm Running `target/debug/wadm` RUST_LOG was not set or the given directive was invalid: FromEnvError { kind: Env(NotPresent) } Defaulting logger to `info` level {"timestamp":"2023-09-12T14:33:16.518961Z","level":"INFO","fields":{"message":"event: connected"},"target":"async_nats::options"} thread 'main' panicked at 'span 'new' had malformed fields! this is a bug. error: EOF while parsing a value at line 1 column 0 fields: FormattedFields { fields: "", formatter: tracing_subscriber::fmt::format::DefaultFields, was_ansi: true }', /workspace/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-subscriber-0.3.17/src/fmt/format/json.rs:197:49 note: run with `RUST_BACKTRACE=1` environment variable to display a backtraceRelated Issues
partially addresses #147
Release Information
next
Consumer Impact
enables structured logging without crashing
Testing
See above command
Built on platform(s)
Tested on platform(s)
Unit Test(s)
none
Acceptance or Integration
none
Manual Verification
see above command
Comments
I think additionally the rest of the issue may need addressing with a deeper refactor, and we can use other projects as a guide of sorts (like linkerd2-proxy here https://github.com/linkerd/linkerd2-proxy/blob/main/linkerd/tracing/src/lib.rs)