feat(spreadscaler): Assign leftover instances by weight, instead of spread order #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedtadde
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
…licas based on weight Signed-off-by: Ahmed Tadde <ahmedtaddde@gmail.com> Signed-off-by: Ahmed Tadde <ahmedtadde@gmail.com>
ahmedtadde
force-pushed
the
feat/compute-spread-enhancement
branch
from
ea91193
to
765806f
Compare
brooksmtownsend
requested changes
Sep 12, 2023
…l for computed spreads output Signed-off-by: Ahmed <ahmedtadde@gmail.com>
ahmedtadde
force-pushed
the
feat/compute-spread-enhancement
branch
from
6c0dda4
to
a650071
Compare
brooksmtownsend
requested changes
Sep 13, 2023
…hould be fine; will be revisited later if needed. Signed-off-by: Ahmed <ahmedtadde@gmail.com>
brooksmtownsend
approved these changes
Sep 14, 2023
|
Thank you @ahmedtadde 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The existing implementation of compute_spread favors spread requirements defined earlier in the YAML, rather than the ones with the highest weight. With the updated implementation, leftover replicas are distributed based on weight.
Related Issues
Addresses #154
Release Information
v0.6.0
Consumer Impact
N/A
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
The following tests are modified to align with the new implementation where order by weight does matter.
Acceptance or Integration
Manual Verification