fix: implement model name sort in model listing #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emattiza
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
emattiza
force-pushed
the
fix/iss-156-name-sort-model-list
branch
from
12c4103
to
fe6efc8
Compare
thomastaylor312
previously approved these changes
Sep 11, 2023
emattiza
force-pushed
the
fix/iss-156-name-sort-model-list
branch
from
fe6efc8
to
fe0f98d
Compare
updates app listing to be sorted on model name closes wasmCloud#156 Signed-off-by: Evan Mattiza <emattiza@gmail.com>
emattiza
force-pushed
the
fix/iss-156-name-sort-model-list
branch
from
fe0f98d
to
ca2108a
Compare
thomastaylor312
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
updates app listing to be sorted on model name
Related Issues
closes #156
Release Information
next
Consumer Impact
anyone listing models with wadm will now have a default sort applied
Testing
None added, but happy to implement with the right pointers
Built on platform(s)
Tested on platform(s)
Unit Test(s)
None added, but happy to add
Acceptance or Integration
None added, but happy to add
Manual Verification
Ran wadm build against sample app and saw a stable sort on repeated invocations