Add Actor and Provider Daemonscalers #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
from
689afa0
to
697d391
Compare
brooksmtownsend
changed the title
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
from
697d391
to
ca9b6e5
Compare
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
from
ca9b6e5
to
8a20575
Compare
thomastaylor312
previously approved these changes
Sep 5, 2023
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
2 times, most recently
from
1b6e3c0
to
17baae7
Compare
brooksmtownsend
changed the base branch from
main
to
fix/shared-provider-usage
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> refactored for correct logic Signed-off-by: Brooks Townsend <brooks@cosmonic.com> fixed issue with no spread requirements Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
from
17baae7
to
8858616
Compare
thomastaylor312
previously approved these changes
Sep 5, 2023
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> cleanup Signed-off-by: Brooks Townsend <brooks@cosmonic.com> allow cleanup for provider Signed-off-by: Brooks Townsend <brooks@cosmonic.com> added test, fix pr comment Signed-off-by: Brooks Townsend <brooks@cosmonic.com> removed wait for washboard Signed-off-by: Brooks Townsend <brooks@cosmonic.com> so no head? Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
feat/daemonscaler
branch
from
8858616
to
15ad855
Compare
thomastaylor312
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds a new scaler type, the
daemonscaler, which is a drop-in replacement for thespreadscalertrait. Instead of spreading a certain number of replicas across a specified set of constraints, thedaemonscalerspreads a certain number of replicas across all hosts in a lattice that match the requirements of the spread.Kubernetes developers can think of a Spreadscaler as a k8s deployment with label selectors, and the Daemonscaler as a k8s DaemonSet (with optional label selectors)
More documentation will be needed here (PR forthcoming), but just so you know:
weightentirelyreplicasfield, as you can only run one copy of a provider per host.Related Issues
N/A
Release Information
v0.6.0
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Added unit tests for the actor daemonscaler to ensure spreading logic works
Acceptance or Integration
Manual Verification
I manually tested this working with and without constraints.