Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Implement onAbort especially for legacy 3.4.2 (3.x branch) without changing logic on 4.x branches #3288

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

afwn90cj93201nixr2e1re
Copy link

Read first comment

@afwn90cj93201nixr2e1re
Copy link
Author

afwn90cj93201nixr2e1re commented Aug 9, 2020

https://codesandbox.io/s/vue-routing-example-pfhhb - Bug example.

How to reproduce:
Open link and read description.
Posva don't wanna change 4.0 logic, that's why we should do it only for 3.x, not for 4.0/

As you can see it's already fixed in 4.0 (#2079) but most ppls still using 3.x and have this issue.

Expained one year ago before 4.0 development started, related links:

#3027 (comment)
#2956 (comment)

So, im not the only one person who undestand that it's not properly designed and should be fixed/added at least in vue 3.x branch.
#3157 (but it's not really available for understand)

P.s im waiting for that since october 2019, (1 year carl), but posva's opinion is: I don't wanna implement it and i don't wanna make a brekable changes. (#3157 (comment))

Introducing an api to remove it right away is, for me, worse that the breaking change because it's likely to create more confusion than the breaking change itself: returned Promise by router.push should be resolved/rejected after internal redirects (next('/other'))

So, shotly, i don't wanna implement neither.

So, my opinion is: vue-router is inside vue infrastructure (official), if you haven't solution rn, maybe then you should implement temporary solution and then deprecate it? I think there's no better ways to do it rn.

It's not disrespectful/rude, im just saying it as person who just tired waiting for fix and you are forgot about this issue each time when start's writing RFC (idk how rfc related to old branch). You are just don't listening to ppls which are coding on vue RN and founding more and more bugs which should be fixed asap, instead waiting for better solution which are not gonna be brekable (in most cases it's also impossible, in this one it's impossible and this pr the only one right solution) and so on sometimes you are just closing issues and being disrespectful to ppls which are reporting bugs, and after that you are saying to ppls that they are disrespectful to you.

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re changed the title Implement onAbort especially for legacy 3.4.2 (3.x branch) without changing logic on 4.x branches [3.x] Implement onAbort especially for legacy 3.4.2 (3.x branch) without changing logic on 4.x branches Aug 9, 2020
@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re marked this pull request as draft August 24, 2020 08:50
@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re marked this pull request as ready for review August 24, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant