block creation of File['root_npmrc'] when running on Windows #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file resource causes the puppet-nodejs module to fail on Windows. Excluding it seems to make the module work. Installed node-red and node-red-contrib-amqp on Windows via npm package provider successfully with this change.
…s-elide-root_npmrc block creation of File['root_npmrc'] when running on Windows
|
@jhicks-camgian Can you provide further detail - what Puppet version, log output etc? |
|
Puppet 5.5.1 was used but this is an error that would seem to affect any version when used on Windows. The code under the condition applied in the pull request assumes a Unix user/group schema with a root user. When applied on a Windows system it attempts to create a '.npmrc' file in /root owned by uid root/gid 0 (which is not possible on Windows). |
|
Have created #366 to track a proper fix |
juniorsysadmin
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File['root_npmrc'] resource causes module to fail on Windows.