feat: Improve performance of stack function #1281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1233
Well this was a fun challenge. This PR improves the performance of the stack, substack, and stackSubgroups functions. It also refactors them so that they all use a single common function.
I tested this against a ~1,600 item dataset. Before the change, stacking took 4.6 seconds. After the change it takes 84 milliseconds.
I think the new algorithm is O(n log n) for the best case (order of items matches chronological order) and O(n^2) for the worst case (order of items is the exact inverse of chronological order). I believe the previous stacking algorithm was actually O(n^2 log n), and not the O(n^2) mentioned in yotamberk/timeline-plus#26. But I'm not a computer scientist, so someone else would have to confirm this.
I have tested this using the "subgroups" example and it appears to maintain the same stacking behaviour. I've also tested it with a large dataset in my employer's application and it looks identical there too. But I realise that this isn't exactly extensive testing, so please let me know if there's anything I missed.