Upgraded go and golangci-lint #963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchen-vertica
requested review from
roypaulin,
fenic-fawkes,
HaoYang0000,
qindotguan and
LiboYu2
as code owners
roypaulin
reviewed
Oct 21, 2024
| @@ -172,7 +172,7 @@ func (s *StatusReconciler) calculateSubclusterStatus(ctx context.Context, sc *va | |||
| return err | |||
| } | |||
|
|
|||
| for podIndex := int32(0); podIndex < int32(len(curStat.Detail)); podIndex++ { | |||
| for podIndex := int32(0); podIndex < int32(len(curStat.Detail)); podIndex++ { //nolint:gosec | |||
There was a problem hiding this comment.
I see many occurrences of //nolint:gosec. Why is that?
There was a problem hiding this comment.
The new version of golangci-lint has a more strict type check. The type conversion int32(xxx) will be reported by go lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades GO to the latest version (1.23.2) for fixing vulnerabilities CVE-2022-30635, CVE-2024-34156, and CVE-2024-34158.
Go 1.23.2 requires golangci-lint to be version 1.60.0 or higher, so I upgraded golangci-lint to the latest version, 1.61.0.