feat: allow adding extra ports and manifests #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to add metrics thanks to the plugin https://github.com/freight-hub/verdaccio-openmetrics, we need to expose the ports.
Changes made
extraPorts
value, that contain a list of ports to add to the service and container.extraManifests
value, that contain a list of kubernetes manifests to deploy within the chart. This is very useful to, for example, add a ServiceMonitor so the service is scraped by prometheus.Notes
This is not a breaking change, as the new variables are a list with a default empty one and there is a range to iterate over them.