Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow adding extra ports and manifests #151

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

jchanam
Copy link
Contributor

@jchanam jchanam commented Aug 27, 2024

Motivation

In order to add metrics thanks to the plugin https://github.com/freight-hub/verdaccio-openmetrics, we need to expose the ports.

Changes made

  • Add a extraPorts value, that contain a list of ports to add to the service and container.
  • Add a extraManifests value, that contain a list of kubernetes manifests to deploy within the chart. This is very useful to, for example, add a ServiceMonitor so the service is scraped by prometheus.
  • (fix) Add a default name (http) for the service port.

Notes

This is not a breaking change, as the new variables are a list with a default empty one and there is a range to iterate over them.

@juanpicado juanpicado changed the title Allow adding extra ports and manifests feat: allow adding extra ports and manifests Oct 1, 2024
@juanpicado juanpicado merged commit 417e902 into verdaccio:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants