Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove(deployment): the 'replicas' field from the helm template if not used by user #142

Merged
merged 4 commits into from
Mar 19, 2024
Merged

remove(deployment): the 'replicas' field from the helm template if not used by user #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35a79d6
fix(deployment): conflict between ArgoCD and Keda
alexis974 Feb 27, 2024
5550fdb
bump(chart): version
alexis974 Mar 5, 2024
2ca9eb1
Merge branch 'verdaccio:master' into fix/keda-argocd-conflict
alexis974 Mar 19, 2024
e87f33d
fix(deployment): type comparaison
alexis974 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ and their default values.
| `priorityClass.enabled` | Enable specifying pod priorityClassName | `false` |
| `priorityClass.name` | PriorityClassName to be specified in pod spec | `""` |
| `replicaCount` | Desired number of pods | `1` |
| `replicaCountEnabled` | Enable the replicaCount field | `true` |
| `livenessProbe` | Configuration of liveness probe | `{}` |
| `readinessProbe` | Configuration of readiness probe | `{}` |
| `resources` | CPU/Memory resource requests/limits | `{}` |
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: A lightweight private node.js proxy registry
name: verdaccio
version: 4.16.0
version: 4.16.1
appVersion: 5.29.0
home: https://verdaccio.org
icon: https://cdn.verdaccio.dev/logos/default.png
Expand Down
2 changes: 2 additions & 0 deletions charts/verdaccio/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
{{- if .Values.replicaCountEnabled }}
replicas: {{ default 1 .Values.replicaCount }}
{{- end}}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
Expand Down
1 change: 1 addition & 0 deletions charts/verdaccio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ podLabels: {}
##
podAnnotations: {}

replicaCountEnabled: true
replicaCount: 1

revisionHistoryLimit: 10
Expand Down
Loading