Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add log message for bans in the notif channel #519

Merged
merged 1 commit into from
May 17, 2024
Merged

add log message for bans in the notif channel #519

merged 1 commit into from
May 17, 2024

Conversation

hyper-neutrino
Copy link
Contributor

Summary of Changes

  • add a log embed (similar to the one for when spammers are kicked) to when the ban command is used
  • the old reply will obviously still show up

Motivation and Explanation

  • currently, bans are only indicated as responses to the command invocation
  • logs will make this information more readily available and better formatted

Related Issues

Steps to Reproduce

  • use /ban

Demonstration of Changes

image

probro27
probro27 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyper-neutrino LGTM!

@hyper-neutrino hyper-neutrino merged commit 92c6d15 into main May 17, 2024
2 checks passed
@hyper-neutrino hyper-neutrino deleted the hyper/436/log-bans branch May 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probro27 probro27 probro27 approved these changes

@Fan-Yang-284 Fan-Yang-284 Awaiting requested review from Fan-Yang-284

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log bans as a new message instead of replies
2 participants
@hyper-neutrino @probro27