Skip to content

Commit

Permalink
React18 support (#34)
Browse files Browse the repository at this point in the history
* chore: upgrade modules to support react18

* fix: declare a children as a props

VFC is get obsolete and now FC is it

* fix: fix react typing error

React says, the child of `ReactPortal` should be ReactNode

```
Type 'FunctionComponentElement<never>' is not assignable to type 'ReactNode'.
  Property 'children' is missing in type 'FunctionComponentElement<never>' but required in type
  'ReactPortal'.ts(2322)
```

* fix(test): recent way to fire dom event in the test
  • Loading branch information
hachibeeDI authored May 29, 2022
1 parent ed00ab5 commit caadc9d
Show file tree
Hide file tree
Showing 7 changed files with 117 additions and 100 deletions.
180 changes: 98 additions & 82 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"@commitlint/cli": "^13.1.0",
"@commitlint/config-conventional": "^13.1.0",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@testing-library/react": "^13.2.0",
"@types/jest": "^27.0.1",
"@types/react": "^17.0.20",
"@types/react": "^18.0.9",
"@typescript-eslint/eslint-plugin": "^4.31.0",
"@typescript-eslint/parser": "^4.31.0",
"babel-jest": "^27.1.0",
Expand All @@ -63,8 +63,8 @@
"lint-staged": "^11.1.2",
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react": "^18.1.0",
"react-dom": "^18.1.0",
"standard-version": "^9.3.1",
"typescript": "^4.4.2"
},
Expand Down
Loading

0 comments on commit caadc9d

Please sign in to comment.