Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added styling to chat screen header #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added styling to chat screen header #301

wants to merge 1 commit into from

Conversation

arwendowers
Copy link

@arwendowers arwendowers commented Oct 4, 2024 •
edited
Loading

For Issue #268, I changed the styling of the chat screen header to match the Figma design. I replaced the previous placeholder header container with the NearbyHeader component and then styled the component. I left placeholders for the nearby count icon and back arrow icon, but they still need implementation.

dyland88
dyland88 requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@dyland88 dyland88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks really good. The left chevron gets a bit cut off on my device. To fix this, you could try setting the height and width to percentages instead of absolute values.
header image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyland88 dyland88 dyland88 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arwendowers @dyland88