You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GitHub Actions CI workflow to use macos-13 instead of macos-latest due to compatibility issues with OOMMF M1 conda package on newer macOS versions.
Removed unnecessary setup for headless display to simplify the workflow.
Changes walkthrough 📝
Relevant files
Configuration changes
workflow.yml
Update macOS version and streamline CI workflow
.github/workflows/workflow.yml
Changed macOS version in CI from 'macos-latest' to 'macos-13' to avoid issues with missing OOMMF M1 conda package.
Removed setup for headless display in CI workflow.
2, because the changes are straightforward and limited to the CI configuration file, specifically updating the macOS version and removing a setup step. The impact of these changes is clear and localized.
🧪 Relevant tests
No
⚡ Possible issues
Compatibility Issue: Changing the macOS version to 'macos-13' might introduce compatibility issues with other tools or dependencies not explicitly mentioned in the PR.
🔒 Security concerns
No
Code feedback:
relevant file
.github/workflows/workflow.yml
suggestion
Consider adding a fallback macOS version in the matrix to ensure compatibility for future macOS updates. This can be done by adding an additional entry to the os array, such as 'macos-12', to handle cases where 'macos-13' might not be available or compatible with certain tools in the future. [medium]
Specify a more precise macOS version to ensure compatibility.
Consider specifying a more specific macOS version instead of just 'macos-13' to ensure compatibility with Intel CPUs, as the PR title suggests issues with the M1 chip. For instance, use 'macos-13.2' if it is known to work well with the required software and hardware.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
…kage is still missing
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
PR Type
enhancement, configuration changes
Description
macos-13instead ofmacos-latestdue to compatibility issues with OOMMF M1 conda package on newer macOS versions.Changes walkthrough 📝
workflow.yml
Update macOS version and streamline CI workflow.github/workflows/workflow.yml
issues with missing OOMMF M1 conda package.