Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Roles #53

Merged
merged 1 commit into from
Aug 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/datastore/roles.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,25 @@
}
}

Roles ListRoles() {
std::string_view qry = R"(
select
_id,
_rev,
name

Check warning on line 84 in src/datastore/roles.cpp

View check run for this annotation

Codecov / codecov/patch

src/datastore/roles.cpp#L83-L84

Added lines #L83 - L84 were not covered by tests
from roles
)";

auto res = pg::exec(qry);

Roles roles;
for (const auto &r : res) {
roles.push_back(Role(r));
}

return roles;
}

Role RetrieveRole(const std::string &id) {
std::string_view qry = R"(
select
Expand Down
3 changes: 2 additions & 1 deletion src/datastore/roles.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,6 @@ class Role {

using Roles = std::vector<Role>;

Role RetrieveRole(const std::string &id);
Roles ListRoles();
Role RetrieveRole(const std::string &id);
} // namespace datastore
20 changes: 20 additions & 0 deletions src/svc/roles.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,19 @@ grpc::ServerUnaryReactor *Roles::Create(
return reactor;
}

grpc::ServerUnaryReactor *Roles::List(
grpc::CallbackServerContext *context, const gk::v1::RolesListRequest *request,
gk::v1::RolesListResponse *response) {
auto *reactor = context->DefaultReactor();

// TODO: error handling
auto roles = datastore::ListRoles();
map(roles, response);

reactor->Finish(grpc::Status::OK);
return reactor;
}

grpc::ServerUnaryReactor *Roles::Retrieve(
grpc::CallbackServerContext *context, const gk::v1::RolesRetrieveRequest *request,
gk::v1::Role *response) {
Expand Down Expand Up @@ -86,4 +99,11 @@ void Roles::map(const datastore::Role &from, gk::v1::Role *to) {
Permissions::map(perm, p);
}
}

void Roles::map(const datastore::Roles &from, gk::v1::RolesListResponse *to) {
for (const auto &role : from) {
auto r = to->add_data();
Roles::map(role, r);
}
}
} // namespace svc
5 changes: 5 additions & 0 deletions src/svc/roles.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,17 @@ class Roles final : public gk::v1::Roles::CallbackService {
grpc::CallbackServerContext *context, const gk::v1::RolesCreateRequest *request,
gk::v1::Role *response) override;

grpc::ServerUnaryReactor *List(
grpc::CallbackServerContext *context, const gk::v1::RolesListRequest *request,
gk::v1::RolesListResponse *response) override;

grpc::ServerUnaryReactor *Retrieve(
grpc::CallbackServerContext *context, const gk::v1::RolesRetrieveRequest *request,
gk::v1::Role *response) override;

static datastore::Role map(const gk::v1::RolesCreateRequest *from);

static void map(const datastore::Role &from, gk::v1::Role *to);
static void map(const datastore::Roles &from, gk::v1::RolesListResponse *to);
};
} // namespace svc
26 changes: 26 additions & 0 deletions src/svc/roles_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,32 @@ TEST_F(svc_RolesTest, Create) {
}
}

TEST_F(svc_RolesTest, List) {
svc::Roles svc;

// Success: list roles
{
grpc::CallbackServerContext ctx;
grpc::testing::DefaultReactorTestPeer peer(&ctx);
gk::v1::RolesListResponse response;

gk::v1::RolesListRequest request;

datastore::Role role({
.id = "id:svc_RolesTest.List",
});
ASSERT_NO_THROW(role.store());

auto reactor = svc.List(&ctx, &request, &response);
EXPECT_TRUE(peer.test_status_set());
EXPECT_TRUE(peer.test_status().ok());
EXPECT_EQ(peer.reactor(), reactor);

EXPECT_EQ(response.data().size(), 1);
EXPECT_EQ(response.data()[0].id(), role.id());
}
}

TEST_F(svc_RolesTest, Retrieve) {
svc::Roles svc;

Expand Down