Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split protos #43

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Split protos #43

merged 11 commits into from
Jul 21, 2023

Conversation

uatuko
Copy link
Owner

@uatuko uatuko commented Jul 18, 2023

Having all gRPC endpoints in one service and all protobuf messages in one .proto file is getting a bit out of hand due larger files. This change is to split out gRPC endpoints (and protobuf messages) into multiple services (and files) to keep them more manageable.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 88.12% and project coverage change: +0.19 🎉

Comparison is base (680d1db) 89.47% compared to head (e9dacfa) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   89.47%   89.66%   +0.19%     
==========================================
  Files          29       28       -1     
  Lines        1453     1451       -2     
  Branches      108      108              
==========================================
+ Hits         1300     1301       +1     
+ Misses        132      129       -3     
  Partials       21       21              
Impacted Files Coverage Δ
src/svc/events.cpp 76.92% <76.92%> (ø)
src/svc/rbac.cpp 82.55% <82.55%> (ø)
src/svc/access.cpp 86.23% <86.23%> (ø)
src/svc/roles.cpp 97.22% <97.22%> (ø)
src/svc/collections.cpp 85.82% <100.00%> (ø)
src/svc/identities.cpp 82.69% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@uatuko uatuko marked this pull request as ready for review July 20, 2023 22:55
@uatuko uatuko merged commit 10b5c15 into main Jul 21, 2023
7 of 8 checks passed
@uatuko uatuko deleted the feature/split-protos branch July 21, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant