Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jw/unify auth #1273

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

Jw/unify auth #1273

wants to merge 74 commits into from

Conversation

shopifyski
Copy link
Contributor

No description provided.

shopifyski and others added 29 commits March 27, 2024 11:04
This fixes an issue where a db gets restored from bottomless and doesn't
get any writes until shutdown. At this point, the current generation is
the same as the restored one but the graceful shutdown process expects
to wait for that generation to be uploaded which never happens because
there are no writes. This change adds a snapshot generation emit call at
restore time to allow graceful shutdown to happen when there are no
writes without having to checkpoint and upload a new snapshot.
fix deadlock on read transaction upgrade
* server: fix interactive txn schema panic

* fix txn check

* fix check errors

* Apply suggestions from code review

---------

Co-authored-by: ad hoc <postma.marin@protonmail.com>
Don't build inside the source tree because `cargo clean` won't clean up
after it...
* server: add shutdown timeout

* add config cli/env var for timeout

* wire timeout
…1256)

allow explain queries without bind parameters

In SQLite, it is invalid to pass a query with a ? or named parameter
without a bind variable, unless you are just trying to explain the
command.

We always fail those queries, but we shouldn't.
…ly equivalent to the previous form. No change in logic.
@haaawk
Copy link
Contributor

haaawk commented Jul 25, 2024

Are you still working on this @shopifyski ? If not, please close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants