Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlfluff fix command #822

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix sqlfluff fix command #822

merged 1 commit into from
Jul 15, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Jul 9, 2024

Fixes 2 issues:

  • In some scenarios (such as when there are still issues after autofixes), sqlfluff fix will nonzero exit code, causing a linter failure presently. It will still format, so there's no other need for triage
  • sqlfluff soft-deprecated the --force flag (it's now default on), so we can get ahead of that

Copy link

trunk-io bot commented Jul 9, 2024

⏱️ 15m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 5m 🟩
Trunk Check runner [linux] 3m 🟩
Linter Tests ubuntu-latest 3m 🟩
Linter Tests macOS 2m 🟩
CodeQL-Build 1m 🟩
Repo Tests / Plugin Tests 31s 🟩
Detect changed files 4s 🟩
Aggregate Test Results 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review July 9, 2024 20:46
@TylerJang27 TylerJang27 requested a review from det July 9, 2024 20:46
@TylerJang27 TylerJang27 merged commit 6bc8ad4 into main Jul 15, 2024
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/sqlfluff-fixes branch July 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants