create services/install-gitlab.sh (fixes #2139)
#2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLKwong
changed the title
tests/resolution.batsservices/install-gitlab.sh (fixes #2139)
rjpadilla
reviewed
Apr 5, 2021
services/install-gitlab.sh
Outdated
| mkdir -p /srv/gitlab | ||
|
|
||
| # create yml(s) | ||
| {version: '3.3' |
There was a problem hiding this comment.
I get an error when I run services gitlab install:
Maybe related to this line not having a space (check codeclimate https://codeclimate.com/github/treehouses/cli/pull/2159).
There was a problem hiding this comment.
Fixed the Code Climate error. 😌🎉
rjpadilla
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Good: It works
Bad:
- It takes about four minutes to boot up to the login screen.
- My pi ends up bricked several minutes later.
- Can't connect to port 443 and 2222
All in all, the bad points come from my end (I'm surprised I even made it to the gitlab page with my 2gbs of ram), so I'll give it my 👍
rjpadilla
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.