Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-uninstall: add page #14201

Merged
merged 11 commits into from
Oct 16, 2024
Merged

npm-uninstall: add page #14201

merged 11 commits into from
Oct 16, 2024
+16 −0

Conversation

Bucke200
Copy link
Contributor

@Bucke200 Bucke200 commented Oct 14, 2024 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 14, 2024
sebastiaanspeck
sebastiaanspeck reviewed Oct 14, 2024
View reviewed changes
pages/common/npm-uninstall.md Outdated Show resolved Hide resolved
pages/common/npm-uninstall.md Outdated Show resolved Hide resolved
Bucke200 and others added 3 commits October 14, 2024 22:03
@Bucke200 @sebastiaanspeck
Update pages/common/npm-uninstall.md
26901ff 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@Bucke200 @sebastiaanspeck
Update pages/common/npm-uninstall.md
60f9e74 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@Bucke200
Merge branch 'main' into patch-6
2f9eca3
acuteenvy
acuteenvy previously requested changes Oct 14, 2024
View reviewed changes
pages/common/npm-uninstall.md Outdated Show resolved Hide resolved
@Bucke200
Copy link
Contributor Author

@sebastiaanspeck should i remove the --save-dev command then?

@sebastiaanspeck
Copy link
Member

@sebastiaanspeck should i remove the --save-dev command then?

Yes, please do so.

renie
renie approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@renie renie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Bucke200 @sebastiaanspeck
Update pages/common/npm-uninstall.md
eaf6c73 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/npm-uninstall.md:17: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

@Bucke200
Copy link
Contributor Author

@sebastiaanspeck please merge this PR

@sebastiaanspeck sebastiaanspeck merged commit 18e00ff into tldr-pages:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renie renie renie approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@acuteenvy acuteenvy Awaiting requested review from acuteenvy

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bucke200 @sebastiaanspeck @tldr-bot @renie @acuteenvy