-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to Phoenix HTML 4.1, bump dependencies #4277
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @sdwalker for your changes! |
Tests failing? |
Yeah, I assume this is the cause:
|
The mix files need cleaned to only have the phoenix changes and not include the rest of the unrelated package updates The gettext warnings are simple fixes when updating gettext The dependencies that aren't keeping up with package releases (websockex, timex) are another source of warnings |
I fixed it with the help of https://www.yellowduck.be/posts/fixing-the-gettext-warning-in-phoenix |
It looks like this function call teslamate/test/teslamate/vault_test.exs Line 11 in 30a947a
This puzzles me though, I don't see any changes here. Oh, I think this change upgraded Clock, so we got this breaking change: danielberkompas/cloak@267077e. Which is typical fashion wasn't documented as a breaking change :-( https://github.com/danielberkompas/cloak/blob/master/CHANGELOG.md |
If I am reading the stack trace correctly, this is returning an error tuple: teslamate/lib/teslamate/locations.ex Line 58 in 30a947a
Which seems to indicate we are getting here somehow: teslamate/test/support/mocks/geocoder.ex Line 150 in 2fc749c
|
They match the local changes I've been using |
No description provided.