Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to Phoenix HTML 4.1, bump dependencies #4277

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JakobLichterfeld
Copy link
Collaborator

No description provided.

@JakobLichterfeld JakobLichterfeld added dependencies Pull requests that update a dependency file area:teslamate Related to TeslaMate core labels Oct 19, 2024
@JakobLichterfeld JakobLichterfeld mentioned this pull request Oct 19, 2024
1 task
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 30a947a
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/67168198c8fe580008486cf7
😎 Deploy Preview https://deploy-preview-4277--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld
Copy link
Collaborator Author

Thanks @sdwalker for your changes!

@brianmay
Copy link
Collaborator

Tests failing?

@JakobLichterfeld
Copy link
Collaborator Author

Tests failing?

Yeah, I assume this is the cause:

warning: defining a Gettext backend by calling

    use Gettext, otp_app: ...

is deprecated. To define a backend, call:

    use Gettext.Backend, otp_app: :my_app

Then, instead of importing your backend, call this in your module:

    use Gettext, backend: MyApp.Gettext

  lib/teslamate_web/gettext.ex:23: TeslaMateWeb.Gettext (module)

@JakobLichterfeld JakobLichterfeld marked this pull request as draft October 20, 2024 08:35
@sdwalker
Copy link
Contributor

The mix files need cleaned to only have the phoenix changes and not include the rest of the unrelated package updates

The gettext warnings are simple fixes when updating gettext

The dependencies that aren't keeping up with package releases (websockex, timex) are another source of warnings
Bulma can be updated to 1.0.2 if you ignore the slew of deprecation warnings but their devs are keeping up

@JakobLichterfeld JakobLichterfeld changed the title feat: update to Phoenix HTML 4.1 feat: update to Phoenix HTML 4.1, bump dependencies Oct 21, 2024
@JakobLichterfeld
Copy link
Collaborator Author

Yeah, I assume this is the cause:

warning: defining a Gettext backend by calling

    use Gettext, otp_app: ...

is deprecated. To define a backend, call:

    use Gettext.Backend, otp_app: :my_app

Then, instead of importing your backend, call this in your module:

    use Gettext, backend: MyApp.Gettext

  lib/teslamate_web/gettext.ex:23: TeslaMateWeb.Gettext (module)

I fixed it with the help of https://www.yellowduck.be/posts/fixing-the-gettext-warning-in-phoenix

@brianmay
Copy link
Collaborator

brianmay commented Oct 21, 2024

It looks like this function call

|> Cloak.Vault.read_config()
is returning a tuple, and we do not expect a tuple.

This puzzles me though, I don't see any changes here.

Oh, I think this change upgraded Clock, so we got this breaking change: danielberkompas/cloak@267077e.

Which is typical fashion wasn't documented as a breaking change :-(

https://github.com/danielberkompas/cloak/blob/master/CHANGELOG.md

@brianmay
Copy link
Collaborator

If I am reading the stack trace correctly, this is returning an error tuple:

{:ok, attrs} = @geocoder.details(addresses, lang)

Which seems to indicate we are getting here somehow:

throw({:error, :boom})

@sdwalker
Copy link
Contributor

Yeah, I assume this is the cause:

warning: defining a Gettext backend by calling

    use Gettext, otp_app: ...

is deprecated. To define a backend, call:

    use Gettext.Backend, otp_app: :my_app

Then, instead of importing your backend, call this in your module:

    use Gettext, backend: MyApp.Gettext

  lib/teslamate_web/gettext.ex:23: TeslaMateWeb.Gettext (module)

I fixed it with the help of https://www.yellowduck.be/posts/fixing-the-gettext-warning-in-phoenix

They match the local changes I've been using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:teslamate Related to TeslaMate core dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants