-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(main/plutolang): rename to libpluto, use php scripts to build #21269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions and a bit of housekeeping, but looks mostly fine.
Also goes without saying, please squash your commits.
|
beb9840
to
1d8dc42
Compare
428c2b1
to
523da07
Compare
If you want to rebase your feature branch locally I recommend the following. First of, in your local fork repo, add the upstream repo as a remote.
Your feature branch is now up to date. |
fa4b4d7
to
d714faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor nits, but I don't see any substantive blockers.
bdcfdb4
to
114e0f1
Compare
114e0f1
to
02380d5
Compare
498c7be
to
f20719d
Compare
272c48a
to
75b83aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do remember to replace the commit message with something more appropriate.
Other than that, LGTM.
75b83aa
to
900e75f
Compare
900e75f
to
beb8844
Compare
Closes #21255