Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering features and metrics in the ModelCardGenerator #256

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

codesue
Copy link
Contributor

@codesue codesue commented Jul 14, 2023

Model Card Toolkit supports filtering features and metrics when annotating a model card. This change surfaces features_include, features_exclude, metrics_include, and metrics_exclude parameters to enable filtering features and metrics through the ModelCardGenerator component as well.

Fixes issue reported in the tfxa Google Group.

  • Tests pass
  • Appropriate changes to README are included in PR

@github-actions
Copy link
Contributor

Thanks for the PR! 🚀

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

@codesue codesue marked this pull request as ready for review July 14, 2023 23:14
Copy link
Collaborator

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM, but I don't know this code well enough to really be sure.

@codesue
Copy link
Contributor Author

codesue commented Jul 17, 2023

It LGTM, but I don't know this code well enough to really be sure.

Thanks for the review, Robert! In that case, maybe @hanneshapke can take a look before merging this.

Copy link
Member

@casassg casassg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@codesue
Copy link
Contributor Author

codesue commented Jul 19, 2023

/merge

@casassg
Copy link
Member

casassg commented Jul 19, 2023

/merge

@casassg
Copy link
Member

casassg commented Jul 19, 2023

/merge again bc I had to fix a small part in automerge bot

@github-actions github-actions bot merged commit f872831 into tensorflow:main Jul 19, 2023
7 of 8 checks passed
@github-actions
Copy link
Contributor

Merged with approvals from rcrowe-google - thanks for the contribution! 🎉

@codesue codesue deleted the codesue/model-card-generator branch July 19, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants