-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable filtering features and metrics in the ModelCardGenerator #256
Enable filtering features and metrics in the ModelCardGenerator #256
Conversation
Thanks for the PR! 🚀 Instructions: Approve using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It LGTM, but I don't know this code well enough to really be sure.
Thanks for the review, Robert! In that case, maybe @hanneshapke can take a look before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
/merge |
/merge |
/merge again bc I had to fix a small part in automerge bot |
Merged with approvals from rcrowe-google - thanks for the contribution! 🎉 |
Model Card Toolkit supports filtering features and metrics when annotating a model card. This change surfaces
features_include
,features_exclude
,metrics_include
, andmetrics_exclude
parameters to enable filtering features and metrics through theModelCardGenerator
component as well.Fixes issue reported in the tfxa Google Group.