Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an inner fill to the pointer and the ability to stroke inside the pointer #49

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Adds an inner fill to the pointer and the ability to stroke inside the pointer #49

wants to merge 18 commits into from

Commits on May 10, 2022

  1. Adds Kotlin to project 

    Updates Gradle
Updates project to Java 11
Updates Support Library
    @jonathan-livly
    jonathan-livly committed May 10, 2022
    Configuration menu
    Copy the full SHA
    01dc498 View commit details
    Browse the repository at this point in the history

  2. Updates AndroidManifest.xml with required exported attribute 

    Removes redundant label
    @jonathan-livly
    jonathan-livly committed May 10, 2022
    Configuration menu
    Copy the full SHA
    73c2206 View commit details
    Browse the repository at this point in the history

  3. Converts MainActivity to Kotlin using stale branch's changes

    @jonathan-livly
    jonathan-livly committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e64c58c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Converts CircularSeekBar to Kotlin as CircularSeekBarV2.kt

    @jonathan-livly
    jonathan-livly committed May 11, 2022
    Configuration menu
    Copy the full SHA
    198e919 View commit details
    Browse the repository at this point in the history

  2. Deletes old CircularSeekBar.java 

    Renames CircularSeekBarV2.kt to CircularSeekBar.kt
    @jonathan-livly
    jonathan-livly committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d931014 View commit details
    Browse the repository at this point in the history

  3. Removes Hungarian notation. Should now be backwards compatible with o… 

    …ld getters and setters

https://jakewharton.com/just-say-no-to-hungarian-notation/
    @jonathan-livly
    jonathan-livly committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d6f7673 View commit details
    Browse the repository at this point in the history

  4. Adds the ability to have an inner fill color on the pointer and speci… 

    …fy the width.

Deprecates less clear name `pointerStrokeWidth` with `pointerWidth`
    @jonathan-livly
    jonathan-livly committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2ebc504 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Merge branch 'master' of https://github.com/tankery/CircularSeekBar i… 

    …nto feature/03-adds-fill-to-pointer

� Conflicts:
�	app/build.gradle
�	app/src/main/AndroidManifest.xml
�	build.gradle
�	circularSeekBar/build.gradle
�	circularSeekBar/src/main/java/me/tankery/lib/circularseekbar/CircularSeekBar.kt
�	gradle/wrapper/gradle-wrapper.properties
    @jonathan-livly
    jonathan-livly committed May 18, 2022
    Configuration menu
    Copy the full SHA
    901972d View commit details
    Browse the repository at this point in the history

  2. Removes fill from square pointer example

    @jonathan-livly
    jonathan-livly committed May 18, 2022
    Configuration menu
    Copy the full SHA
    1da0714 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Reverts changes to to api names

    @jonathan-livly
    jonathan-livly committed May 23, 2022
    Configuration menu
    Copy the full SHA
    097d674 View commit details
    Browse the repository at this point in the history

  2. Ensures pointerFillInnerStrokeWidth is never negative

    @jonathan-livly
    jonathan-livly committed May 23, 2022
    Configuration menu
    Copy the full SHA
    07060b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Adds name space to README.md

    @jonathan-livly
    jonathan-livly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0d7c056 View commit details
    Browse the repository at this point in the history

  2. Reverts name change for DEFAULT_POINTER_STROKE_WIDTH

    @jonathan-livly
    jonathan-livly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ff29588 View commit details
    Browse the repository at this point in the history

  3. Renames pointer fill properties to the much clearer name pointer overlay

    @jonathan-livly
    jonathan-livly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    725f951 View commit details
    Browse the repository at this point in the history

  4. Fixes bug related to using Paint.Style.FILL_AND_STROKE instead of `… 

    …Paint.Style.STROKE` that caused a visual bug when used in conjuction with `pointerAngle`
    @jonathan-livly
    jonathan-livly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c0634f7 View commit details
    Browse the repository at this point in the history

  5. Removes * from imports

    @jonathan-livly
    jonathan-livly committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    402a987 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Adjust imports order

    @jonathan-livly
    jonathan-livly committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    ef92ce3 View commit details
    Browse the repository at this point in the history

  2. Saves instance state of pointerOverlayBorderWidth

    @jonathan-livly
    jonathan-livly committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    7c3e0cc View commit details
    Browse the repository at this point in the history