Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ser2tcp as a universal binary #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmosca
Copy link

@mmosca mmosca commented Apr 27, 2024

My Makefile fu is a bit rusty, but I believe this gets the job done.

Also, clean had rm *, Was that a typo for *?

@stronnag
Copy link
Owner

My Makefile fu is a bit rusty, but I believe this gets the job done.

Also, clean had rm *, Was that a typo for *?

Huum interesting typo.
Thanks for PR.

@stronnag
Copy link
Owner

Unfortunately this precludes building on older MacOS (and maybe pure x86_64).

make ser2tcp
cc -O2 -Wall -Wextra -pedantic -std=gnu17 -target x86_64-apple-macos11  -s  ser2tcp.c   -o ser2tcp
clang: error: invalid Darwin version number: macos11
clang: error: invalid version number in '--target=x86_64-apple-macos11'

and my MacOs foo is woefully deficient to address this.

So rather than trouble you further, I'll fix this by adding this PR to generate Makefile.macos11 => (make -f Makefile.macos11) to avoid further Makefile complexity.

@mmosca
Copy link
Author

mmosca commented Apr 27, 2024

Can you share a full uname -a of your mac?
I can try check if it is at least a given version before trying to build universal

@stronnag
Copy link
Owner

Just a crappy old VM

macbox:~ jrh$ uname -r
19.6.0
macbox:~ jrh$ uname -a
Darwin macbox 19.6.0 Darwin Kernel Version 19.6.0: Tue Jun 21 21:18:39 PDT 2022; root:xnu-6153.141.66~1/RELEASE_X86_64 x86_64

If it didn't want more than 100% of the extant disk space to update it, then I'd update it. It's only there so I can build some MacOS CLI tools I maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants