[semver:patch] Fix false positive notification assessments

strigo · Jan 19, 2023 · 2bcab3d · 2bcab3d
1 parent 13c6064
commit 2bcab3d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/dist/development/strigo.sdk.js b/dist/development/strigo.sdk.js
@@ -13032,8 +13032,8 @@ ${JSON.stringify(parsedContext)}` : "");
       const { recordedAssessment, challengeSuccessEvent, _id } = assessment;
       const { actionType, expectedText } = recordedAssessment;
       if (actionType === "notification" /* NOTIFICATION */ && expectedText) {
-        const notificationText = window.document.body.innerText?.toLowerCase();
-        if (notificationText.indexOf(expectedText.toLowerCase())) {
+        const bodyText = window.document.body.innerText?.toLowerCase();
+        if (bodyText.length > 100 && bodyText.indexOf(expectedText.toLowerCase()) !== -1) {
           LoggerInstance.info("*** Found notification text. Sending success event...");
           window.Strigo.sendEvent(challengeSuccessEvent);
         }

diff --git a/dist/production/strigo.sdk.min.js b/dist/production/strigo.sdk.min.js
diff --git a/src/modules/no-code-assessment/no-code-assessment.ts b/src/modules/no-code-assessment/no-code-assessment.ts
@@ -338,9 +338,9 @@ const evaluateAssessments = function (): void {
     const { actionType, expectedText } = recordedAssessment;
 
     if (actionType === AssessmentActionType.NOTIFICATION && expectedText) {
-      const notificationText = window.document.body.innerText?.toLowerCase();
+      const bodyText = window.document.body.innerText?.toLowerCase();
 
-      if (notificationText.indexOf(expectedText.toLowerCase())) {
+      if (bodyText.length > 100 && bodyText.indexOf(expectedText.toLowerCase()) !== -1) {
         Logger.info('*** Found notification text. Sending success event...');
 
         window.Strigo.sendEvent(challengeSuccessEvent);