Fix CI with new Ubuntu LTS #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses CI issues by adjusting the GitHub Actions workflow to accommodate Ubuntu version changes and CodSpeed compatibility. The changes primarily focus on modifying the test matrix generation and benchmark processes. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Ckk3 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
+ Coverage 96.67% 97.01% +0.34%
==========================================
Files 503 503
Lines 33457 33457
Branches 5602 5618 +16
==========================================
+ Hits 32344 32459 +115
+ Misses 880 792 -88
+ Partials 233 206 -27 |
CodSpeed Performance ReportMerging #3667 will not alter performanceComparing Summary
|
patrick91
reviewed
Oct 11, 2024
.github/workflows/test.yml
Outdated
| @@ -24,10 +24,12 @@ jobs: | |||
| sessions: ${{ steps.set-matrix.outputs.sessions }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - run: pip install poetry nox nox-poetry | |||
| - run: python3 -m venv .venv | |||
There was a problem hiding this comment.
Sure! I didn’t change it earlier because I wanted to minimize changes, but I will make this changes on this PR.
DoctorJohn
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our CI started getting some new erros, I've checked that CodSpeed doesn't support Ubuntu 24.04 LTS (lastest LTS).
This PR fixes
Unit tests / 💻 Generate test matrix (pull_request)andUnit tests / 📈 Benchmarks (pull_request)workflows by bring back ubuntu 22.04 onBenchmarksand using a Virtual Enviroment onGenerate Test Matrixto follow PEP 668 on new ubuntu version.Is also important see that 22.04 LTS will be updated until April 2027
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Update CI workflows to address compatibility issues with the latest Ubuntu LTS by reverting to Ubuntu 22.04 for benchmarks and using a virtual environment for test matrix generation.
CI: