-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests and lints to nox #2931
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 96.17% 96.16% -0.01%
==========================================
Files 211 211
Lines 9223 9231 +8
Branches 1704 1489 -215
==========================================
+ Hits 8870 8877 +7
Misses 227 227
- Partials 126 127 +1 |
Apollo Federation Subgraph Compatibility Results
Learn more: |
forgot to add coverage 🤦 |
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature. Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion.
Other than that, looks awesome! :)
Closes #2275
Closes #2247
This PR moves our tests to use nox instead of matrixes on GitHub actions 😊