Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests and lints to nox #2931

Merged
merged 31 commits into from
Jul 8, 2023
Merged

Move tests and lints to nox #2931

merged 31 commits into from
Jul 8, 2023

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jul 7, 2023

Closes #2275
Closes #2247

This PR moves our tests to use nox instead of matrixes on GitHub actions 😊

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #2931 (6d64a2d) into main (6dd5552) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.01%     
==========================================
  Files         211      211              
  Lines        9223     9231       +8     
  Branches     1704     1489     -215     
==========================================
+ Hits         8870     8877       +7     
  Misses        227      227              
- Partials      126      127       +1     

@botberry
Copy link
Member

botberry commented Jul 7, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@patrick91 patrick91 marked this pull request as ready for review July 8, 2023 13:23
@patrick91 patrick91 requested a review from bellini666 July 8, 2023 13:24
@patrick91 patrick91 marked this pull request as draft July 8, 2023 13:24
@patrick91
Copy link
Member Author

forgot to add coverage 🤦

@botberry
Copy link
Member

botberry commented Jul 8, 2023

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@patrick91 patrick91 marked this pull request as ready for review July 8, 2023 15:30
Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion.

Other than that, looks awesome! :)

noxfile.py Show resolved Hide resolved
@patrick91 patrick91 changed the title Another attempt at nox :) Move tests and lints to nox Jul 8, 2023
@patrick91 patrick91 merged commit 100c682 into main Jul 8, 2023
41 of 43 checks passed
@patrick91 patrick91 deleted the nox branch July 8, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants