Clear error flags on a serial read #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the "27.6.1 Status register (USART_SR)" of the reference manual in case if error flag bit is set during the read, software needs to clear it by reading SR and DR registers.
Basically it is a copy of the
stm32f1xx-hallibSerial::readimplementation: https://github.com/stm32-rs/stm32f1xx-hal/blob/e36195ed3ea4512ffe5fa0683d7cc510e54cc4b5/src/serial.rs#L348-L388 , but since I'm not an expert in an embedded field, it would be nice to check it once again.