Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32-fmc #759

Merged
merged 3 commits into from
Aug 3, 2024
Merged

stm32-fmc #759

merged 3 commits into from
Aug 3, 2024

Conversation

burrbull
Copy link
Contributor

No description provided.

@burrbull burrbull force-pushed the stm32-fmc branch 5 times, most recently from 2ed6c8c to 23ff9b4 Compare June 14, 2024 03:35
@burrbull burrbull marked this pull request as ready for review June 14, 2024 03:35
@burrbull burrbull force-pushed the stm32-fmc branch 4 times, most recently from 2551381 to c84b996 Compare June 16, 2024 04:36
//! off-chip SDRAM memory device. The `stm32-fmc` crate does the majority of the work, and
//! after initialization the SDRAM is memory mapped to the STM32F7 address space.
//!
//! This example was tested on the STM32F746G Discovery Board. The board has an IS42S32400F-6BL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the example actually mentions a real STM32F4xx usecase, it's hard to see how to apply this to a F4 board.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using the branch from this PR on an STM32F469I-DISC board, example here which does a memory test.

However, that code is blocked on stm32-fmc having the SDRAM chip for that board added (PR here), so I'm just using local clones of these two crate repos for now... perhaps once stm32-fmc changes are merged we can combine examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work as expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you correct PR example to make it more F4?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 100%, but depends on the other chip being added to stm32-fmc; once that is available I'd be happy to bring my memory test here (or you can feel free to take it and adapt, either way).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using the branch from this PR on an STM32F469I-DISC board, example here which does a memory test.

Replaced example with yours (disabled for now).
As we do not depend on stm32-rs/stm32-fmc#14 directly I'm going to merge this PR.
So we will need just enable example when stm32-fmc is released.

@burrbull burrbull merged commit a7f9d10 into master Aug 3, 2024
22 checks passed
@burrbull burrbull deleted the stm32-fmc branch October 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants