Made signed int add and sub more efficient. #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
Merged
orizi
force-pushed
the
spr/main/861630ee
branch
3 times, most recently
from
6461cd2
to
adcf8fc
Compare
orizi
force-pushed
the
spr/main/b1bb85ba
branch
from
957613f
to
0332314
Compare
orizi
force-pushed
the
spr/main/861630ee
branch
2 times, most recently
from
c93f0b0
to
a7d0fc7
Compare
orizi
force-pushed
the
spr/main/b1bb85ba
branch
from
0332314
to
180bf5f
Compare
orizi
force-pushed
the
spr/main/861630ee
branch
from
a7d0fc7
to
be90c7d
Compare
orizi
force-pushed
the
spr/main/b1bb85ba
branch
from
180bf5f
to
5747d40
Compare
gilbens-starkware
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
gilbens-starkware
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Reviewable status:
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.
Fixing #6462.
commit-id:861630ee
orizi
force-pushed
the
spr/main/861630ee
branch
from
be90c7d
to
d472062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue with returning the proper saturating value on
Saturating{Add,Sub}.Fixing #6462.
This change is