Refactor collector config #1885
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
force-pushed
the
mauro/refactor-collector-config
branch
from
4356bd1
to
f5fec46
Compare
Changes done: - Remove InitCollectorConfig and replace it with a proper constructor. - Delete default constructor. - Created multiple helper methods in order to split initialization of the configuration. - Inlined several simple getters and setters for consistency. - Removed static constexpr variables that could be directly applied as default member initializers. - Replaced const char*[] with std::array.
The heuristics may fail if the builder container is not running as privileged, but they are also not needed for unit testing, so we can just skip them. Normal collector operation will always execute the heuristics.
Molter73
force-pushed
the
mauro/refactor-collector-config
branch
from
9ea2727
to
41627e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EnvVarvariables to further simplify configuration handling.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed