Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-26516: Collector reads runtime config from configmap #1878

Merged
merged 16 commits into from
Oct 9, 2024
Merged

ROX-26516: Collector reads runtime config from configmap #1878

merged 16 commits into from
Oct 9, 2024

Commits on Oct 4, 2024

  1. X-Smart-Branch-Parent: master

    @JoukoVirtanen
    JoukoVirtanen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8e90325 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Set the runtime config form a configmap

    @JoukoVirtanen
    JoukoVirtanen committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    892083b View commit details
    Browse the repository at this point in the history

  2. It is possible to set the path from which the configmap is read using… 

    … an environment variable
    @JoukoVirtanen
    JoukoVirtanen committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    eca3531 View commit details
    Browse the repository at this point in the history

  3. Improved logging

    @JoukoVirtanen
    JoukoVirtanen committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    fd7e684 View commit details
    Browse the repository at this point in the history

  4. If the configmap is not read in or is empty, don't parse it

    @JoukoVirtanen
    JoukoVirtanen committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    1a7c1a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Update collector/test/CollectorConfigTest.cpp 

    Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
    @JoukoVirtanen @Molter73
    JoukoVirtanen and Molter73 authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    836992b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
Co-authored-by: Simon Bäumer <baeumer@pm.me>
    @JoukoVirtanen @Molter73 @SimonBaeumer
    3 people authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b3805d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Using yaml instead of json

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    060ad4f View commit details
    Browse the repository at this point in the history

  2. Added a bit more error handling

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    150a561 View commit details
    Browse the repository at this point in the history

  3. Install yaml-cpp from source (#1880) 

    Co-authored-by: Olivier Valentin <ovalenti@redhat.com>
    @Molter73 @ovalenti
    Molter73 and ovalenti authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    bdbbe52 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
    @JoukoVirtanen @Molter73
    JoukoVirtanen and Molter73 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    da78c7c View commit details
    Browse the repository at this point in the history

  5. Addressed additional pr review comments

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    497d102 View commit details
    Browse the repository at this point in the history

  6. Changed the default path. Added log for runtimeconfig

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fb7669e View commit details
    Browse the repository at this point in the history

  7. Minor change to logging

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c3e1306 View commit details
    Browse the repository at this point in the history

  8. Added info to references.md

    @JoukoVirtanen
    JoukoVirtanen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fb994de View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Removed unneeded if in unit test

    @JoukoVirtanen
    JoukoVirtanen committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    39e8aad View commit details
    Browse the repository at this point in the history