-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-26065: Observability subchart teardown #2075
Conversation
{{/* Keep the namespace to retain PVCs after uninstall */}} | ||
helm.sh/resource-policy: keep | ||
labels: | ||
argocd.argoproj.io/managed-by: openshift-gitops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for smooth migration to argo cd. This subchart is going to be removed after the migration is completed
e7296c2
to
624dd57
Compare
dp-terraform/helm/rhacs-terraform/charts/observability/templates/01-operator-01-namespace.yaml
Outdated
Show resolved
Hide resolved
…es/01-operator-01-namespace.yaml Co-authored-by: Ludovic Cleroux <ludydoo@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Problem
When you uninstall the obserability helm subchart, the CR is deleted together with the operator and the namespace, which causes the CR and the namespace to remain stuck in the uninstallation state
Proposed solution
In order to shutdown the observability operator gracefully you need to perform the following sequence of actions:
observability.customResourceEnabled=false
to delete the CR and effectively uninstall prometheus, alertmanager and grafana but, keep the operator and most importantly the PVCs associated with prometheus and alertmanager.observability.enabled=false
to uninstall the operatorAs a result, the
rhacs-observability
namespace and the PVCs are NOT removed in order to retain the existing metrics.Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts