Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26065: Observability subchart teardown #2075

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Oct 17, 2024

Description

Problem

When you uninstall the obserability helm subchart, the CR is deleted together with the operator and the namespace, which causes the CR and the namespace to remain stuck in the uninstallation state

Proposed solution

In order to shutdown the observability operator gracefully you need to perform the following sequence of actions:

  1. Set observability.customResourceEnabled=false to delete the CR and effectively uninstall prometheus, alertmanager and grafana but, keep the operator and most importantly the PVCs associated with prometheus and alertmanager.
  2. Set observability.enabled=false to uninstall the operator

As a result, the rhacs-observability namespace and the PVCs are NOT removed in order to retain the existing metrics.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

{{/* Keep the namespace to retain PVCs after uninstall */}}
helm.sh/resource-policy: keep
labels:
argocd.argoproj.io/managed-by: openshift-gitops
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for smooth migration to argo cd. This subchart is going to be removed after the migration is completed

@kovayur kovayur force-pushed the yury/ROX-26065-obserability-teardown branch from e7296c2 to 624dd57 Compare October 17, 2024 09:03
…es/01-operator-01-namespace.yaml

Co-authored-by: Ludovic Cleroux <ludydoo@gmail.com>
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 7213056 into main Oct 17, 2024
15 checks passed
@kovayur kovayur deleted the yury/ROX-26065-obserability-teardown branch October 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants