597 make sidecar and transformer containers communicate over socket #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7-make-sidecar-and-transformer-containers-communicate-over-socket
BenGalewsky
requested review from
BenGalewsky
and removed request for
Michael-D-Johnson
BenGalewsky
approved these changes
Jul 11, 2023
BenGalewsky
deleted the
597-make-sidecar-and-transformer-containers-communicate-over-socket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sidecar - transformer communication go over a localhost socket.
That is more reliable and performant than communication over files in a shared directory. Upload to s3/minio is now correctly separated from the transformation loop.
Code is much simpler.
It does require a new version of science images coming from ssl-hep/science-images#1