🔧 Modify : 파일/폴더 수정/삭제/위치 변경

🤖 Refactor : 코드 리팩토링
✅ Test : 테스트 코드 추가

1. 통합 테스트를 위해선 난수를 발생시키는 Random 객체를 mock할 필요가 있다.
2. MoneyToPurchaseLotto 내부에서 Random을 생성하면 mock 객체를 주입할 수 없다.
3. args처럼 randome 객체를 외부에서 주입하기 위해 프로그램을 Game으로 한번 더 감쌌다.
4. test할 때 mock random 객체를 Game에 주입해서 통합테스트를 진행할 수 있다.

src/main/java/base/view/ConsoleInput.java

@@ -46,6 +46,6 @@ private void printInputHeader() {
     }
 
     public void close() {
-        scanner.close();
+//        scanner.close();
     }
 }

src/main/java/lotto/Application.java

@@ -1,56 +1,10 @@
 package lotto;
 
-import java.io.ByteArrayInputStream;
-import java.util.Scanner;
-
-import lotto.controller.MoneyConsoleInput;
-import lotto.controller.MoneyToPurchaseLotto;
-import lotto.controller.PurchaseLottoToPrize;
-import lotto.controller.WinningBonusConsoleInput;
-import lotto.controller.WinningLottoConsoleInput;
-import lotto.model.bonus.BonusOutputDto;
-import lotto.model.bonus.IBonusOutput;
-import lotto.model.lotto.winning.IWinningLottoOutput;
-import lotto.model.money.IMoneyInput;
+import java.util.Random;
 
 public class Application {
-
     public static void main(String[] args) {
-        if (args.length < 3) {
-            args = new String[]{"8000", "1,2,3,4,5,6", "7"}; // 사용자 입력을 가정하는 걸로 예상
-        }
-        ByteArrayInputStream actual = new ByteArrayInputStream(
-                String.join(System.lineSeparator(), args).getBytes());
-        System.setIn(actual);
-        Scanner scanner = new Scanner(System.in);
-        // 구입 금액 입력
-        IMoneyInput money;
-        try (var console = MoneyConsoleInput.of(scanner)) {
-            money = console.getInput();
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-
-        // 로또 구매
-        var purchasedLotto = MoneyToPurchaseLotto.of().tryConvert(money);
-
-        // 당첨 로또 번호 입력
-        IWinningLottoOutput winningLotto;
-        try (var console = WinningLottoConsoleInput.of(scanner)) {
-            winningLotto = IWinningLottoOutput.of(console.getInput());
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-
-        // 보너스 번호 입력
-        IBonusOutput bonusNumber;
-        try (var console = WinningBonusConsoleInput.of(winningLotto, scanner)) {
-            bonusNumber = BonusOutputDto.of(console.getInput());
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-
-        // 당첨 통계 출력
-        PurchaseLottoToPrize.of(winningLotto, bonusNumber).tryConvert(purchasedLotto);
+        Game game = new Game(args, new Random());
+        game.runGame();
     }
 }

src/main/java/lotto/Game.java

@@ -0,0 +1,60 @@
+package lotto;
+
+import lotto.controller.*;
+import lotto.model.bonus.BonusOutputDto;
+import lotto.model.bonus.IBonusOutput;
+import lotto.model.lotto.winning.IWinningLottoOutput;
+import lotto.model.money.IMoneyInput;
+
+import java.io.ByteArrayInputStream;
+import java.util.Random;
+import java.util.Scanner;
+
+public class Game {
+    private final String[] args;
+    private final Random random;
+    public Game(String[] args, Random random) {
+        this.args = args;
+        this.random = random;
+    }
+
+    public void runGame(){
+
+        if (args.length >= 3) {
+            ByteArrayInputStream actual = new ByteArrayInputStream(
+                    String.join(System.lineSeparator(), args).getBytes());
+            System.setIn(actual);
+        }
+
+        Scanner scanner = new Scanner(System.in);
+        // 구입 금액 입력
+        IMoneyInput money;
+        try (var console = MoneyConsoleInput.of(scanner)) {
+            money = console.getInput();
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+
+        // 로또 구매
+        var purchasedLotto = MoneyToPurchaseLotto.of(random).tryConvert(money);
+
+        // 당첨 로또 번호 입력
+        IWinningLottoOutput winningLotto;
+        try (var console = WinningLottoConsoleInput.of(scanner)) {
+            winningLotto = IWinningLottoOutput.of(console.getInput());
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+
+        // 보너스 번호 입력
+        IBonusOutput bonusNumber;
+        try (var console = WinningBonusConsoleInput.of(winningLotto, scanner)) {
+            bonusNumber = BonusOutputDto.of(console.getInput());
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+
+        // 당첨 통계 출력
+        PurchaseLottoToPrize.of(winningLotto, bonusNumber).tryConvert(purchasedLotto);
+    }
+}

src/main/java/lotto/controller/MoneyToPurchaseLotto.java

@@ -14,14 +14,16 @@
 
 public class MoneyToPurchaseLotto extends Converter<IMoneyInput, ILottoPurchaseOutput> {
 
-    public MoneyToPurchaseLotto(View<ILottoPurchaseOutput> view) {
+    private final Random random;
+    private MoneyToPurchaseLotto(View<ILottoPurchaseOutput> view, Random random) {
         super(view);
+        this.random = random;
     }
 
-    public static MoneyToPurchaseLotto of() {
+    public static MoneyToPurchaseLotto of(Random random) {
         return new MoneyToPurchaseLotto(
-                new LottoPurchaseOutputView()
-        );
+                new LottoPurchaseOutputView(),
+                random);
     }
 
     @Override
@@ -35,7 +37,6 @@ public ILottoPurchaseOutput convert(IMoneyInput iMoneyInput) {
     }
 
     private LottoOutputDto generateRandomLotto() {
-        var random = new Random();
         var numbers = new TreeSet<Integer>();
         while (numbers.size() < 6) {
             numbers.add(random.nextInt(45) + 1);

src/test/java/lotto/ApplicationTest.java

@@ -2,12 +2,17 @@
 
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Random;
+
 import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import org.mockito.Mockito;
+import org.mockito.stubbing.OngoingStubbing;
+import static org.mockito.Mockito.when;
 
 public class ApplicationTest {
     private final String lf = System.lineSeparator();
@@ -24,34 +29,50 @@ void tearDown() {
         System.setOut(System.out);
     }
 
-    @Disabled
+//    @Disabled
     @DisplayName("Application 실행 테스트")
     @Test
     void integrationTest() {
         // given
+        // 무작위로 생성되는 Random 변수를 제어할 수 없을까?
         String[] args = {"8000", "1,2,3,4,5,6", "7"};
-        String expected = makeStringByArgs(args);
+        Random randomNumberMock = Mockito.mock(Random.class);
+        int [][] randomValues = new int[][]{
+                {1, 2, 3, 41, 42, 43},
+            {1, 2, 9, 41, 42, 43},
+            {3, 5, 11, 16, 32, 38},
+                {7, 11, 16, 35, 36, 44},
+                {13, 14, 16, 38, 42, 44},
+                {2, 13, 22, 32, 38, 41},
+                {2, 13, 22, 32, 38, 43},
+                {2, 13, 22, 32, 38, 42}
+        };
+        String expected = makeStringByArgs(args, randomValues);
+        OngoingStubbing<Integer> stubbing = when(randomNumberMock.nextInt(45));
+        for (int[] values : randomValues) {
+            for (int value : values) {
+                stubbing = stubbing.thenReturn(value);
+            }
+        }
+
         // when
-        Application.main(args);
+        Game game = new Game(args, randomNumberMock);
+        game.runGame();
         // then
-        Assertions.assertEquals(expected.trim(), actual.toString().trim());
+        assertEquals(expected.trim(), actual.toString().trim());
     }
 
-    private String makeStringByArgs(String[] args) {
-        String inputMoney = "구입금액을 입력해 주세요." + lf + args[0] + lf;
-        String outputPurchasedLotto = """
-                8개를 구매했습니다.
-                [8, 21, 23, 41, 42, 43]
-                [3, 5, 11, 16, 32, 38]
-                [7, 11, 16, 35, 36, 44]
-                [1, 8, 11, 31, 41, 42]
-                [13, 14, 16, 38, 42, 45]
-                [7, 11, 30, 40, 42, 43]
-                [2, 13, 22, 32, 38, 45]
-                [1, 3, 5, 14, 22, 45]
-                """.replace("\n", lf);
-        String inputWinningLotto = "당첨 번호를 입력해 주세요." + lf + args[1] + lf;
-        String inputWinningBonus = "보너스 번호를 입력해 주세요." + lf + args[2] + lf;
+    private String makeStringByArgs(String[] args, int[][] randomValues) {
+        String inputMoney = "구입금액을 입력해 주세요." + lf ; //+ args[0] + lf;
+        StringBuilder sb = new StringBuilder();
+        sb.append(String.format("%d개를 구매했습니다.\n",8));
+        for(int i=0; i<randomValues.length; i++){
+            sb.append(Arrays.toString(Arrays.stream(randomValues[i]).map(n->n+1).toArray()));
+            sb.append("\n");
+        }
+        String outputPurchasedLotto = sb.toString();
+        String inputWinningLotto = "당첨 번호를 입력해 주세요." + lf; // + args[1] + lf;
+        String inputWinningBonus = "보너스 번호를 입력해 주세요." + lf; // + args[2] + lf;
         String outputPrizeStatistics = """
                 당첨 통계
                 ---

src/test/java/lotto/controller/LottoPurchaseTest.java

@@ -2,11 +2,7 @@
 
 import java.io.ByteArrayInputStream;
 import java.util.Scanner;
-
-import lotto.model.money.MoneyInputValidator;
-import lotto.view.sin.MoneyInputView;
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -19,11 +15,11 @@ private MoneyConsoleInput getController(Scanner scanner) {
         return MoneyConsoleInput.of(scanner);
     }
 
-    @Disabled
-    @DisplayName("음이 아닌 Integer에 대한 돈 발행")
+//    @Disabled
+    @DisplayName("1000에 나눠 떨어지는 Integer에 대한 돈 발행")
     @ParameterizedTest
-    @ValueSource(ints = {0, 1, 1000, Integer.MAX_VALUE})
-    void inputMoney(int number) {
+    @ValueSource(ints = {1000,2000,3000})
+    void inputDontHaveRemainMoney(int number) {
         // given
         String input = number + lf;
         ByteArrayInputStream in = new ByteArrayInputStream(input.getBytes());
@@ -34,6 +30,20 @@ void inputMoney(int number) {
         // then
         Assertions.assertDoesNotThrow(controller::tryInput);
     }
+    @DisplayName("1000에 나눠 떨어지지 않는 Integer에 대한 돈 발행")
+    @ParameterizedTest
+    @ValueSource(ints = {0, 1, Integer.MAX_VALUE})
+    void inputHaveRemainMoney(int number) {
+        // given
+        String input = number + lf;
+        ByteArrayInputStream in = new ByteArrayInputStream(input.getBytes());
+        System.setIn(in);
+        System.setIn(new ByteArrayInputStream(input.getBytes()));
+        var controller = getController(new Scanner(System.in));
+
+        // then
+        Assertions.assertThrows(IllegalArgumentException.class,controller::tryInput);
+    }
 
     @DisplayName("음수로는 돈 발행 불가")
     @ParameterizedTest