Remove the implementations folder since it is not maintained #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move all build instructions to a build.sh in the language-specific folder - update GitHub Actions to avoid deprecation warnings - remove implementations folder - it contained various unmaintained and untested scripts - simplify rebench.conf - it’s not tested, so, this is more of a template of how a setup may look like Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to clean up the repository, and reduce the number of things floating around that are not actually used.
The new convention is to have a
build.shscript per language.The script, if necessary builds the benchmarks.
build.sh ${langId}should be supported if there are slight difference between concrete language implementations, that need a build step.build.sh styleshould run language-specific style checkers on the benchmark code.