Implement parsing of Appcast items from XML data

slidoapp · Oct 25, 2023 · d9dc4f2 · d9dc4f2
1 parent 7cac656
commit d9dc4f2
Show file tree

Hide file tree

Showing 7 changed files with 553 additions and 65 deletions.
diff --git a/Sources/Appcast/Constants.swift b/Sources/Appcast/Constants.swift
@@ -46,3 +46,8 @@ public struct SURSSElement {
     public static let PubDate = "pubDate"
     public static let Title = "title"
 }
+
+public struct SURSSAttribute {
+    public static let URL = "url"
+    public static let Length = "length"
+}
diff --git a/Sources/Appcast/SUAppcast.swift b/Sources/Appcast/SUAppcast.swift
@@ -44,13 +44,14 @@ public class SUAppcast {
                     }
 
                     if let name = self.sparkleNamespacedName(of: currentNode) {
-                        var nodes = nodesDict[name]
-                        if nodes == nil {
-                            nodes = [XMLNode]()
-                            nodesDict[name] = nodes
-                        }
-
-                        nodes?.append(currentNode)
+                        nodesDict[name, default: [XMLNode]()].append(currentNode)
+//                        var nodes = nodesDict[name]
+//                        if nodes == nil {
+//                            nodes = [XMLNode]()
+//                            nodesDict[name] = nodes
+//                        }
+//
+//                        nodes?.append(currentNode)
                     }
 
                     node = currentNode.nextSibling
@@ -61,6 +62,7 @@ public class SUAppcast {
                 let name = nodeInfo.key
                 let nodeSet = nodeInfo.value
                 guard let node = self.bestNode(in: nodeSet, name: name) else {
+                    print("Missing node value for element \(name)")
                     continue
                 }
 
@@ -88,7 +90,7 @@ public class SUAppcast {
                         let attributes = self.attributes(of: node)
                         let descriptionFormat = attributes[SUAppcastAttribute.Format]
 
-                        var descriptionDict = [String: String]()
+                        var descriptionDict = AttributesDictionary()
                         descriptionDict["content"] = description
                         descriptionDict["format"] = descriptionFormat
 
@@ -123,7 +125,7 @@ public class SUAppcast {
                     dict[name] = tags
                 }
                 else if name == SUAppcastElement.InformationalUpdate {
-                    var informationalUpdateVersions = Set<String>()
+                    var informationalUpdateVersions = SUAppcastItem.InformationalUpdateType()
 
                     if let children = node.children {
                         for child in children {
@@ -210,6 +212,8 @@ public class SUAppcast {
         return nodes[preferredLanguageIndex]
     }
 
+    typealias AttributesDictionary = [String: String]
+
     func attributes(of node: XMLNode) -> [String: String] {
         var dictionary = [String: String]()