Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversations.requestSharedInvite.approve/deny APIs #1365

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Sep 12, 2024

This pull request adds two endpoint support to slack-api-client library. Usually, we add end-to-end autoamted tests for this type of addition, but let me skip this time for now. The reason is that it's not so easy to set up such an automation with these APIs. For the future, I don't think these APIs will make lots of changes, so we can do manual testing as necessary.

I'd like to hold off adding conversations.requestSharedInvite.list API this time because it's not yet publicly available.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Sep 12, 2024
@seratch seratch added this to the 1.42.1 milestone Sep 12, 2024
@seratch seratch self-assigned this Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (1d79b18) to head (f0dcace).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/slack/api/methods/RequestFormBuilder.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1365      +/-   ##
============================================
+ Coverage     74.73%   74.78%   +0.05%     
- Complexity     4268     4280      +12     
============================================
  Files           457      457              
  Lines         13278    13299      +21     
  Branches       1369     1370       +1     
============================================
+ Hits           9923     9946      +23     
+ Misses         2553     2550       -3     
- Partials        802      803       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 5003a6e into slackapi:main Sep 13, 2024
6 checks passed
@seratch seratch deleted the connect-governance-apis branch September 13, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants