Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New built-in step Add Canvas to Channel Tab, changes to function generation #367

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 9, 2024

WIP! Do not merge/release before Oct 16.

  • expose new title output parameter on create canvas and channel create canvas steps,
  • canvas_update_content step now calls backwards-compatible canvas_update_content_v2 step under the hood. add support for "id aliases" in function generation to manage these sorts of transitions.

…utput parameter on create canvas and channel create canvas steps, canvas update content step now calls backwards-compatible canvas_update_content_v2 step under the hood. add support for "id aliases" in function generation
@filmaj filmaj added do not merge semver:minor requires a minor version number bump labels Oct 9, 2024
@filmaj filmaj self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 98.76543% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.54%. Comparing base (834464d) to head (4774f88).

Files with missing lines Patch % Lines
...ma/slack/functions/_scripts/src/templates/utils.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          67       68    +1     
  Lines        2742     2817   +75     
  Branches      148      149    +1     
=======================================
+ Hits         2702     2776   +74     
- Misses         40       41    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge semver:minor requires a minor version number bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant