feat: prevent dialogs from blocking password managers

closes #38
simonwep · Jul 6, 2024 · a94eb01 · a94eb01
1 parent 2c559ca
commit a94eb01
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/app/components/base/dialog/Dialog.vue b/src/app/components/base/dialog/Dialog.vue
@@ -41,7 +41,7 @@ watch(
   [toRef(props, 'open'), dialog],
   () => {
     if (props.open) {
-      dialog.value?.showModal();
+      dialog.value?.show();
       requestAnimationFrame(() => (visible.value = true));
     } else {
       visible.value = false;

diff --git a/src/app/components/base/form/TextField.vue b/src/app/components/base/form/TextField.vue
@@ -6,6 +6,7 @@
         :id="inputId"
         ref="input"
         v-model="modelValue"
+        :name="name"
         :minlength="minLength"
         :maxlength="maxLength"
         :required="required"
@@ -43,6 +44,7 @@ const modelValue = defineModel<string>();
 withDefaults(
   defineProps<{
     type?: 'text' | 'password';
+    name?: string;
     minLength?: number;
     maxLength?: number;
     required?: boolean;

diff --git a/src/app/pages/navigation/auth/LoginDialog.vue b/src/app/pages/navigation/auth/LoginDialog.vue
@@ -1,8 +1,8 @@
 <template>
   <Dialog :open="open" :title="t('navigation.auth.welcomeBack')" @close="emit('close')">
     <Form :submit-label="t('navigation.auth.signIn')" @submit="signIn">
-      <TextField v-model="username" required :label="t('navigation.auth.username')" type="text" />
-      <TextField v-model="password" required :label="t('navigation.auth.password')" type="password" />
+      <TextField v-model="username" required :label="t('navigation.auth.username')" type="text" name="username" />
+      <TextField v-model="password" required :label="t('navigation.auth.password')" type="password" name="password" />
       <Alert v-if="state === 'errored'" :text="t('navigation.auth.loginFailed')" type="error" />
     </Form>
   </Dialog>